Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into replacing MvxViewModel and derivatives #4438

Open
Cheesebaron opened this issue Jul 14, 2022 · 1 comment
Open

Look into replacing MvxViewModel and derivatives #4438

Cheesebaron opened this issue Jul 14, 2022 · 1 comment

Comments

@Cheesebaron
Copy link
Member

Cheesebaron commented Jul 14, 2022

I would love to do composition over inheritance for anything MVVM related, such that consumers of MvvmCross can choose to use their own implementation of INotifyPropertyChanged, use CommunityToolkit or perhaps ReactiveUI or whatever they feel like.

Instead of being forced to inherit from MvxViewModel or similar, just because it contains some lifecycle methods that are convenient.

To receive the lifecycle callbacks, could also be a composition detail, such as inheriting from a IMvxViewModelLifecycle interface.

@Cheesebaron Cheesebaron changed the title Look into replacing MvxViewModels and derivatives with CommunityToolkit Look into replacing MvxViewModel and derivatives Jul 14, 2022
@entdark
Copy link
Contributor

entdark commented Jul 15, 2022

Instead of replacing, it could be an addition.
So basically let MvvmCross provide its own implementation as it does now and let it replace with your own if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants