Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework MvxNavigationService #4439

Open
Cheesebaron opened this issue Jul 14, 2022 · 1 comment
Open

Rework MvxNavigationService #4439

Cheesebaron opened this issue Jul 14, 2022 · 1 comment

Comments

@Cheesebaron
Copy link
Member

Cheesebaron commented Jul 14, 2022

The idea behind MvxNavigationService is great. However, the fact that we are using annotations, which create instances of ViewControllers/Fragments/Activities just to look up how to navigate is a huge downside.
Along with that, plus the fact that it is hard to figure out how the navigation tree looks like of the App.

It would be nice to reconceptualize or build further upon the routing navigation that was added on top.

There are also a lot we can do with regards to navigation on various platforms that could be improved significantly, such as Fragment navigation and supporting a lot of the modern functionality that we now have on Android, such as shared transitions, proper control of how Fragments are transacted upon etc.

@qwertylolman
Copy link

i think, ViewModel lifecycle should be redesigned as well. ViewModel should be inside the context of the page (VC/Activity/Fragment/etc). like in the native Android. so navigation will appear between abstract pages, and not between ViewModels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants