Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Typo in drop_policy options in moe_utils.py #815

Open
Malikeh97 opened this issue May 9, 2024 · 2 comments
Open

[BUG] Typo in drop_policy options in moe_utils.py #815

Malikeh97 opened this issue May 9, 2024 · 2 comments

Comments

@Malikeh97
Copy link

Hi,
I have just captured a bug in moe_util.py script. In line 310 of /megatron/core/transformer/moe/moe_utils.py, "prob" should be replaced by "probs".

If not, the code throws the following error while using moe-expert-capacity-factor option:

UnboundLocalError: local variable 'capacity_mask' referenced before assignment

Best,
Malikeh
@felipeliliti
Copy link

Ok obrigado

@Malikeh97
Copy link
Author

Ok obrigado

de nada :)

shamanez added a commit to shamanez/Megatron-LM that referenced this issue May 11, 2024
@shamanez
Update moe_utils.py
70bf9d3 
referring to the issue - 

NVIDIA#815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Malikeh97 @felipeliliti