[Android] Implement vertical center for Label

[kefahB]

Hi,

It will be cool to implement Gravitywith verticalAlignment="center" for Label on android, for the moment we need to implement lloaded event on each label and declare the flowing for each page!

export function lblLoaded(args: EventData) {
	let lbl = <View>args.object;
    if(isAndroid) {
        lbl.android.setGravity(17)
    }
}

[farfromrefug]

@kefahB alreadly working in @nativescript-community/ui-label with verticalTextAlignment. At one point we might be using it in the core too

[NathanWalker]

I think this should be the default in core - iOS defaults to center and Android should be the same. I’ve long been frustrated about this, thanks for bringing this up @kefahB. If no one has good reasons they should remain different let’s just make this the default in 8.4.

I use ui-label all the time as well and I think it would be great for that to replace the core implementation @farfromrefug - using transient or implement directly in core?

[farfromrefug]

@NathanWalker the one thing i am not sure about in making it the default is that the iOS implementation uses UITextView instead of UILabel. Not sure if we care or not ...

[kefahB]

I think it is a good think when we see the same behavior on IOS and android as we develop for both platforms, it cost as less work

[NathanWalker]

#10233

[kefahB]

@NathanWalker Did you intent to push this feature into the 8.0.4 ?

[NathanWalker]

It will be on by default with 8.5.

[NathanWalker]

@kefahB #10233

[kefahB]

@NathanWalker Grate thank you 🙌

[vallemar]

I don't know if this would be nice by default or not, but this feature would definitely be nice. On many occasions you have to put the label in a layout to center it. It would be nice to be able to center it to remove views from layouts

[NathanWalker]

This will be included in 8.5 release: #10233