Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Links #25

Open
jcassidyav opened this issue Jun 4, 2021 · 9 comments
Open

Broken Links #25

jcassidyav opened this issue Jun 4, 2021 · 9 comments

Comments

@jcassidyav
Copy link
Contributor

I used markdown-link-check to check for broken links.
The result is below,

I was going to raise a pull request to fix the ones linking to the api-reference, but am unsure if adding a redirect, or just fixing the link in the md file is the best thing to do ?

I'd be inclined to say fix the links in the markdown.


FILE: advanced-concepts.md

72 links checked.
/binding-generator/extend-class-interface.md → Status: 400

FILE: cli-lang.md

FILE: development-workflow.md
54 links checked.
https://discourse.nativescript.org/c/plugins → Status: 0
/plugins/building-plugins.md → Status: 400
https://www.nativescript.org/books-and-videos → Status: 404

FILE: index.md
25 links checked.
https://github.com/NativeScript/template-master-detail-ts/blob/master/tools/preinstall.js → Status: 404
https://github.com/NativeScript/template-master-detail-ts/blob/master/tools/postinstall.js → Status: 404

FILE: interaction.md
67 links checked.
/api-reference/classes/_ui_core_view_.view.html → Status: 400
/api-reference/interfaces/_ui_animation_.animationdefinition.html → Status: 400
/api-reference/classes/_ui_animation_.animation.html → Status: 400
/api-reference/interfaces/_ui_animation_.pair.html → Status: 400
/api-reference/modules/_ui_enums_.animationcurve.html → Status: 400
/api-reference/classes/_ui_core_view_.view → Status: 400
/api-reference/classes/_ui_core_view_.view → Status: 400

FILE: introduction.md
25 links checked.
https://github.com/NativeScript/template-master-detail-ts/blob/master/tools/preinstall.js → Status: 404
https://github.com/NativeScript/template-master-detail-ts/blob/master/tools/postinstall.js → Status: 404

FILE: performance.md
27 links checked.
/api-reference/modules/_ui_image_.html → Status: 400
/api-reference/modules/_ui_image_.html → Status: 400


FILE: plugins\detox.md
16 links checked.
https://github.com/wix/Detox/blob/master/examples/demo-react-native-jest/e2e/app-hello.e2e.js → Status: 404

FILE: plugins\fingerprint-auth.md
10 links checked.
https://github.com/EddyVerbruggen/nativescript-fingerprint-auth/blob/master/demo/app/vendor-platform.android.ts#L9 → Status: 404
https://godpraksis.no/2016/03/fingerprint-trojan/ → Status: 0


@rigor789
Copy link
Member

rigor789 commented Jun 4, 2021

That's very helpful, thank you!

Yes - we should update these links in the markdown files IMO.

@jcassidyav
Copy link
Contributor Author

Unfortunately markdown-link-check doesn't catch any links that were in the form https://docs.nativescript.org/api-reference/modules/_image_source_ etc. because a status 200 is returned by the 404 page. so there are a lot more links that are not correct.

@jcassidyav
Copy link
Contributor Author

FILE: \advanced-concepts.md

72 links checked.
[✖] https://docs.nativescript.org/core-concepts/application-lifecycle#android-activity-events → Status: 404
[✖] /binding-generator/extend-class-interface.md → Status: 400

FILE: \connectivity.md

4 links checked.
[✖] https://docs.nativescript.org/api-reference/modules/_connectivity_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/enums/_connectivity_.connectiontype → Status: 404

FILE: \development-workflow.md

54 links checked.
[✖] https://docs.nativescript.org/core-concepts/modules → Status: 404
[✖] https://discourse.nativescript.org/c/plugins → Status: 0
[✖] /plugins/building-plugins.md → Status: 400
[✖] https://www.nativescript.org/books-and-videos → Status: 404


FILE: \index.md

25 links checked.
[✖] https://github.com/NativeScript/template-master-detail-ts/blob/master/tools/preinstall.js → Status: 404
[✖] https://github.com/NativeScript/template-master-detail-ts/blob/master/tools/postinstall.js → Status: 404

FILE: \interaction.md

68 links checked.
[✖] /api-reference/classes/view.html → Status: 400
[✖] /api-reference/interfaces/_ui_animation_.animationdefinition.html → Status: 400
[✖] /api-reference/classes/_ui_animation_.animation.html → Status: 400
[✖] /api-reference/classes/_ui_core_view_.view.html → Status: 400
[✖] /api-reference/interfaces/_ui_animation_.pair.html → Status: 400
[✖] /api-reference/modules/_ui_enums_.animationcurve.html → Status: 400
[✖] /api-reference/classes/_ui_core_view_.view → Status: 400
[✖] /api-reference/classes/_ui_core_view_.view → Status: 400
[✖] https://docs.nativescript.org/api-reference/classes/__nativescript_core_.view → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/__nativescript_core_.viewbase → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_dialogs_ → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_dialogs_#action → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_dialogs_.actionoptions → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_dialogs_#alert → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_dialogs_.alertoptions → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_dialogs_#confirm → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_dialogs_.confirmoptions → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_dialogs_#login → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_dialogs_.loginoptions → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_dialogs_.loginresult → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_dialogs_#prompt → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_dialogs_.promptoptions → Status: 404

FILE: \introduction.md

25 links checked.
[✖] https://github.com/NativeScript/template-master-detail-ts/blob/master/tools/preinstall.js → Status: 404
[✖] https://github.com/NativeScript/template-master-detail-ts/blob/master/tools/postinstall.js → Status: 404

FILE: \native-api-access.md

8 links checked.

FILE: \performance.md

27 links checked.
[✖] https://docs.nativescript.org/publishing/publishing-ios-apps → Status: 404
[✖] /api-reference/modules/_ui_image_.html → Status: 400
[✖] /api-reference/modules/_ui_image_.html → Status: 400
[✖] http://docs.nativescript.org/cookbook/ui/image → Status: 404
[✖] http://docs.nativescript.org/angular/code-samples/ui/image.html → Status: 404


FILE: \ui-and-styling.md

140 links checked.
[✖] https://docs.nativescript.org/api-reference/modules/_ui_layouts_absolute_layout_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_layouts_dock_layout_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_layouts_grid_layout_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_layouts_stack_layout_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_layouts_wrap_layout_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_layouts_flexbox_layout_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_core_view_.view → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_action_bar_ → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_action_bar_.actionbar → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_action_bar_.actionitem → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_action_bar_.actionitems → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_action_bar_.navigationbutton → Status: 404
[✖] https://docs.nativescript.org/angular/ui/action-bar → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_activity_indicator_ → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_button_ → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_date_picker_ → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_html_view_ → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_image_source_ → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_enums_.stretch → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_image_.image#loadmode → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_image_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_label_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_list_picker_.htm → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_list_view_ → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_list_view_.listview → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_list_view_.itemeventdata → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_list_view_.itemssource → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_core_view_.keyedtemplate → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_page_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_placeholder_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_progress_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_repeater_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_repeater_.repeater → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_content_view_.contentview → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_scroll_view_.htm → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_search_bar_ → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_segmented_bar_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_slider_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_switch_.html → Status: 404
[✖] https://docs.nativescript.org/ui/image-resources → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_tab_view_.html → Status: 404
[✖] https://docs.nativescript.org/api-reference/interfaces/_ui_tab_view_.selectedindexchangedeventdata → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_text_base_.textbase → Status: 404
[✖] https://docs.nativescript.org/api-reference/classes/_ui_editor_text_base_.editabletextbase → Status: 404
[✖] https://docs.nativescript.org/api-reference/modules/_ui_editor_text_base_#autocapitalizationtype → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_text_field_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_text_view_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_time_picker_.html → Status: 404
[✖] http://docs.nativescript.org/api-reference/modules/_ui_web_view_.html → Status: 404
[✖] https://docs.nativescript.org/cookbook/ui/styling → Status: 404
[✖] https://docs.nativescript.org/ui/dark-mode → Status: 404



FILE: \plugins\detox.md

16 links checked.
[✖] https://github.com/wix/Detox/blob/master/examples/demo-react-native-jest/e2e/app-hello.e2e.js → Status: 404

FILE: \plugins\fingerprint-auth.md

10 links checked.
[✖] https://github.com/EddyVerbruggen/nativescript-fingerprint-auth/blob/master/demo/app/vendor-platform.android.ts#L9 → Status: 404
[✖] https://godpraksis.no/2016/03/fingerprint-trojan/ → Status: 0


FILE: \plugins\social-share.md

4 links checked.
[✖] http://docs.nativescript.org/ApiReference/image-source/ImageSource.html → Status: 404

FILE: \plugins\nativescript-ui\rad-list-view.md

2 links checked.
[✖] https://docs.nativescript.org/ns-ui-api-reference/classes/radlistview → Status: 404

@akshitarora921
Copy link

Hi, Can I work on this?

@rigor789
Copy link
Member

rigor789 commented Oct 6, 2021

@akshitarora921 sure!

@akshitarora921
Copy link

@rigor789 Please assign the issue to me as the list is quite big it will take some time.

@akshitarora921
Copy link

@rigor789 Please provide the list for correct links.

@rigor789
Copy link
Member

rigor789 commented Oct 8, 2021

@akshitarora921 I don't have a list, each has to be inspected individually and then replaced with a new working link.

@akshitarora921
Copy link

@rigor789 please unassign me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants