Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 7.x #78

Open
bobdenotter opened this issue Mar 27, 2021 · 4 comments
Open

Support for PHP 7.x #78

bobdenotter opened this issue Mar 27, 2021 · 4 comments

Comments

@bobdenotter
Copy link

Q A
Library version(s) affected: 4.0.0
PHP version(s): 7.2 and up

Hi,

After the bump to 4.x, there's a hard cutoff for older versions. In our project, we're sticking with Symfony's version support, which means we're supporting PHP 7.2.9 and up. Currently, there's no version of this library that supports both 7.x and 8.x simultaneaously, which means we can't provide a single working setup for our users on different versions of PHP.

Would you consider reverting the dropping of PHP 7.x?

@Ne-Lexa
Copy link
Owner

Ne-Lexa commented Mar 27, 2021

Hello.

The main API is almost identical, except for deleting deprecated functional.

Try to specify the version ^3.3 | ^4.0

@bobdenotter
Copy link
Author

@Ne-Lexa Hi, thanks for the reply.

I know about the |, but for our use case that doesn't work. Our packaged version needs to be able to resolve the dependencies to one version for the lowest supported version, but that needs to work on the highest supported version.

So, in this case, it'll resolve to 3.3.x, but it'll break for people running on PHP 8.

@I-Valchev
Copy link

Hi @Ne-Lexa, indeed like mentioned above it does help a lot of there is one version of the library that supports both 7.x and 8.x. Can we do something to allow you @Ne-Lexa to tag such a release?

Thanks a lot in advance!

Ne-Lexa added a commit that referenced this issue May 16, 2021
Ne-Lexa added a commit that referenced this issue May 16, 2021
Ne-Lexa added a commit that referenced this issue May 16, 2021
Ne-Lexa added a commit that referenced this issue May 16, 2021
issue #78
Ne-Lexa added a commit that referenced this issue May 16, 2021
@bobdenotter
Copy link
Author

Hi,

Not trying to be too insistent, but is there any progress on this? Anything we can do from our end to move it along? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants