Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

[DOC]: No build.gradle changes required for new Mac with an Apple Silicon Chip when Building Conductor From Source #3887

Open
abusk opened this issue Dec 9, 2023 · 0 comments
Labels
type: docs Documentation updates

Comments

@abusk
Copy link

abusk commented Dec 9, 2023

What are you missing in the docs

Building Conductor From Source section in https://conductor.netflix.com/devguide/running/source.html needs to be corrected.

Proposed text

The conductor/grpc/build.gradle is now handling different ISAs, there is no need to manually update for Mac users

The below NOTE should be removed-

NOTE for Mac users: If you are using a new Mac with an Apple Silicon Chip, you must make a small change to conductor/grpc/build.gradle - adding "osx-x86_64" to two lines:

protobuf {
    protoc {
        artifact = "com.google.protobuf:protoc:${revProtoBuf}:osx-x86_64"
    }
    plugins {
        grpc {
            artifact = "io.grpc:protoc-gen-grpc-java:${revGrpc}:osx-x86_64"
        }
    }
...
}
@abusk abusk added the type: docs Documentation updates label Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: docs Documentation updates
Projects
None yet
Development

No branches or pull requests

1 participant