Feature/kan experiment #999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AzulGarza
requested changes
May 10, 2024
There was a problem hiding this comment.
very cool @marcopeix, i left a couple of comments. also i think it might be pretty awesome to release the Auto version as well. perhaps in a different pr, once this one is merged.
elephaint
requested changes
May 13, 2024
There was a problem hiding this comment.
Cool!
- I think we should also add an
AutoKANLinearmodel inmodels.ipynb, I think users will like the ability to have it auto-optimize when they are playing with the architecture. You can just copy-paste most of the code from a comparable MLP-based architecture and change the names. - I think
KANLinearshould also be added tomodels.pyandevaluation.pyin action_files/test_models/src
cchallu
reviewed
May 14, 2024
cchallu
reviewed
May 14, 2024
cchallu
reviewed
May 15, 2024
|
@marcopeix we also need to add KAN to the evaluation pipeline in |
elephaint
approved these changes
May 16, 2024
|
@cchallu I already added KAN to the evaluation pipeline in action_files. Olivier checked it and says it's good! Let me know if I am missing something! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add KAN model
Benchmark of KAN on M3 and M4 dataset against MLP and NBEATS