Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some button labels for better screen reader accessibility #50

Open
marvellousmachine opened this issue May 17, 2024 · 3 comments

Comments

@marvellousmachine
Copy link

I've compiled multiple similar issues into one. I believe these are pretty easy to fix.

  1. "Play / Stop Button" label still present on full screen / maximized window. Just "Play / Stop" is enough.
  2. "Tune down by 100 KHz" & "Tune up by 100 KHz": Just Tune down & Tune up would be enough, I believe, As there are various steps for various bands and purposes.
  3. The chat button needs a proper label. Currently it's just " (0)"or whatever number of unread messages there is. Example solution: "Chat (0 unread)".
  4. The Online users button should have a number of users as part of the label. It's impossible for the screen reader user to access this information on mobile, and on PC it's also cumbersome at best.
  5. The Send button in the chat area lacks the label alltogether. I recommend labelling it as "Send".
@NoobishSVK
Copy link
Owner

Thanks for the feedback. Let me address all the changes.

  1. Play / Stop will be changed in the next update, as per request
  2. Tune up & down buttons will also be updated
  3. The chat button will be updated, it should work properly with the new update
  4. The online users button on desktop will also have a new label, but not on phone, as on the phone this is hidden to save space and this data is actually isnide the panel where you can access settings
  5. Label added, will also be present in the new update

@marvellousmachine
Copy link
Author

Big thanks, everything works perfectly in 1.2.2

@marvellousmachine
Copy link
Author

I've discovered that the label for the Chatbox is still incorrect in the mobile view. Everything else is OK. Sorry for not testing it properly the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants