Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the locking / unlocking accessibility when using screen readers #52

Open
marvellousmachine opened this issue May 17, 2024 · 2 comments

Comments

@marvellousmachine
Copy link

  1. Currently it is not possible to lock / unlock server from the main screen when using a screen reader. You could either make it a HTML button as planned, or use the ARIA role button. When you go for the HTML button version, I suggest you would make the label dynamic: "Lock server" when unlocked and "Unlock server" when locked.
  2. Also it would be helpful if the window title would change in locked state by prepending something like 🔒 or 🔑. For example: "🔒 FM-DX Webserver [Server Name]"
@NoobishSVK
Copy link
Owner

  1. I have added an aria-label (which will be available with the next update).
  2. The icons are already available, but were missing aria-labels, I have added them.

@marvellousmachine
Copy link
Author

Could you also please add the button role for both admin lock and password lock and make them focusable when tabbing?
Also there is a typo: "ock Tuner (Admin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants