New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust-reqwest]: group operations into structs #18636
base: master
Are you sure you want to change the base?
[rust-reqwest]: group operations into structs #18636
Conversation
pub struct DefaultApi; | ||
|
||
let local_var_client = &local_var_configuration.client; | ||
impl DefaultApi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change groups the operations against, in this case, the DefaultApi
into a DefaultApi
struct for organizational purposes.
pub struct {{{classname}}}; | ||
|
||
impl {{{classname}}} { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a preference for sure :) For my part I find Rust code easier to maintain when it is grouped into meaningful structs. I would also be happy to add a feature to control this grouping behavior if we'd like to go that direction.
Fixes: #18637
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)