Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frontend-lint to pre-commit hook #1401

Open
xingyaoww opened this issue Apr 27, 2024 · 0 comments
Open

Add frontend-lint to pre-commit hook #1401

xingyaoww opened this issue Apr 27, 2024 · 0 comments
Labels
enhancement New feature or request frontend issues related to frontend good first issue Good for newcomers severity:medium Problems that affect many users

Comments

@xingyaoww
Copy link
Collaborator

What problem or use case are you trying to solve?

I got frontend lint error after push my code to the PR, which is not caught by pre-commit hooks locally.

Describe the UX of the solution you'd like

Add frontend-lint check to pre-commit hook.

Do you have thoughts on the technical implementation?

Describe alternatives you've considered

Additional context
@xingyaoww xingyaoww added the enhancement New feature or request label Apr 27, 2024
@li-boxuan li-boxuan added the good first issue Good for newcomers label May 1, 2024
@rbren rbren added severity:medium Problems that affect many users frontend issues related to frontend labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request frontend issues related to frontend good first issue Good for newcomers severity:medium Problems that affect many users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rbren @li-boxuan @xingyaoww