Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox: Enable host network whenever possible #1403

Open
rbren opened this issue Apr 27, 2024 · 0 comments
Open

Sandbox: Enable host network whenever possible #1403

rbren opened this issue Apr 27, 2024 · 0 comments
Labels
enhancement New feature or request severity:medium Problems that affect many users

Comments

@rbren
Copy link
Collaborator

rbren commented Apr 27, 2024

What problem or use case are you trying to solve?
Host network is useful for the sandbox, because the agent can start a server on port 3000, and the user can then load a website on that port. Without host network, it's hard for the user to make an HTTP connection into the sandbox.

Use of the host network wasn't possible with Docker Desktop for a long time. Latest versions of Docker Desktop (as of a week or two ago) do allow it though: https://docs.docker.com/network/drivers/host/#:~:text=Host%20networking%20is%20also%20supported,then%20select%20Enable%20host%20networking.

Describe the UX of the solution you'd like
Ideally, we check if host_network works--if so, use it. Otherwise disable and warn.

Do you have thoughts on the technical implementation?
Maybe we can check the version of docker desktop running?

Or even better--try and start a container w/ host network, listening on some port, then try to connect. If it doesn't work, host network is disabled

Describe alternatives you've considered

Additional context

@rbren rbren added the enhancement New feature or request label Apr 27, 2024
@rbren rbren added the severity:medium Problems that affect many users label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request severity:medium Problems that affect many users
Projects
None yet
Development

No branches or pull requests

1 participant