Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix micro-agents schema bug #1424

Merged
merged 8 commits into from Apr 29, 2024
Merged

Conversation

li-boxuan
Copy link
Collaborator

@li-boxuan li-boxuan commented Apr 28, 2024

Some of the micro-agents' agent.yaml have schema definition errors, e.g. RepoExplorerAgent. This PR fixes these bugs. ManagerAgent, however, is not added to integration tests as I can barely get it working with the task in the test: Write a shell script 'hello.sh' that prints 'hello'. Looks like micro-agents are not ready yet and may need more prompt tuning.

You can verify this fix locally by running any task that might trigger RepoExplorerAgent.

Fixes #1423

@li-boxuan li-boxuan marked this pull request as draft April 28, 2024 06:08
@li-boxuan li-boxuan changed the title Fix micro-agents schema and add to CI integration tests Fix micro-agents schema bug Apr 28, 2024
@li-boxuan li-boxuan marked this pull request as ready for review April 28, 2024 06:18
@li-boxuan
Copy link
Collaborator Author

I don't think micro-agents are ready for integration testing yet, so I didn't add them to CI testing.

Copy link
Collaborator

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've been debating whether to add the Agent suffix to everything...

@rbren rbren merged commit 319b9ac into OpenDevin:main Apr 29, 2024
16 checks passed
@li-boxuan li-boxuan deleted the fix-micro-agents branch April 29, 2024 19:00
@li-boxuan
Copy link
Collaborator Author

I've been debating whether to add the Agent suffix to everything

Aha, I had a guess you intentionally did so. But it looks a bit inconsistent as in there's no criteria which shall be an agent and which shall not be. To keep the consistency I added "Agent" as a suffix to each micro-agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RepoExplorer throws AttributeError
3 participants