Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hseditor.HasChanges should more precisely check data #213

Open
gucio321 opened this issue Feb 28, 2021 · 0 comments
Open

hseditor.HasChanges should more precisely check data #213

gucio321 opened this issue Feb 28, 2021 · 0 comments

Comments

@gucio321
Copy link
Contributor

Hi there,
currently our hseditor.HasChanges method does as follows:

                newData := editor.GenerateSaveData()
                if newData != nil {
                        oldData, err := e.Path.GetFileBytes()
                        if err == nil {
                                return !bytes.Equal(oldData, newData)
                        }
                }

but most of our encoders aren't as precise. They are encoding data, but sometimes in a bit changed order e.t.c...
HasChanges should really check if edited (viewed) structure has changes.

@essial essial changed the title hseditor.HasChanges sould more precisely check data hseditor.HasChanges should more precisely check data Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant