Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings should not break Windows build #1512

Closed
tgd opened this issue Jan 25, 2024 · 1 comment
Closed

Deprecation warnings should not break Windows build #1512

tgd opened this issue Jan 25, 2024 · 1 comment
Assignees

Comments

@tgd
Copy link
Contributor

tgd commented Jan 25, 2024

Summary

Windows build breaks, but not others, including Linux.

Some work has been done to try and fix this here: #1514

This PR successfully removes the "bootstrap class path" issue however the build still fails on deprecations.

Goal: build should pass again and not fail on deprecation warnings. We should not need to make any java code changes here, just pom fixes.

bootstrap class path not set in conjunction with -source 8

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/SingleChronicleQueue.java:[505,28] acquireAppender() in net.openhft.chronicle.queue.ChronicleQueue has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/SingleChronicleQueue.java:[167,36] useSparseFiles() in net.openhft.chronicle.queue.impl.single.SingleChronicleQueueBuilder has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/SingleChronicleQueue.java:[753,20] finalize() in java.lang.Object has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/SingleChronicleQueue.java:[754,14] finalize() in java.lang.Object has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/SingleChronicleQueueStore.java:[179,19] shortDump() in net.openhft.chronicle.queue.impl.CommonStore has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/SingleChronicleQueueStore.java:[173,19] dump() in net.openhft.chronicle.queue.impl.CommonStore has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/StoreTailer.java:[1417,24] finalize() in java.lang.Object has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/StoreTailer.java:[1418,18] finalize() in java.lang.Object has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/table/SingleTableStore.java:[192,19] shortDump() in net.openhft.chronicle.queue.impl.CommonStore has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/table/SingleTableStore.java:[169,19] dump() in net.openhft.chronicle.queue.impl.CommonStore has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/StoreAppender.java:[920,24] finalize() in java.lang.Object has been deprecated

/C:/BuildAgent_Java11/work/60de816d62a22c72/src/main/java/net/openhft/chronicle/queue/impl/single/StoreAppender.java:[921,18] finalize() in java.lang.Object has been deprecated

Future work

In the future we will turn on build failure on deprecation - but not now.

@tgd tgd self-assigned this Jan 25, 2024
@tgd tgd changed the title Deprecation warnings break Windows build Deprecation warnings should not break Windows build Jan 29, 2024
@tgd tgd added the review label Jun 3, 2024
@tgd
Copy link
Contributor Author

tgd commented Jun 3, 2024

This has been resolved

@tgd tgd closed this as completed Jun 3, 2024
@tgd tgd removed the review label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant