Killing processes

[LeoRuspini]

Description

Hi all,
thanks for this great work.
I been researching the killing of waiting and active jobs (#114, #1098, #812, #1432). I see the need for a killing method and there is several suggested "solutions", however, none of them seems to work properly plus they involved a lot of extra code (connection to ioredis, broadcast, etc). So in same setup as #1432, after discard and moveToFailed in provider, the job is marked as failed but still kept in waiting ( job.isWaiting(): true, job.isFailed(): true). The current example covers how to kill a job from the local server that run the process. However, the jobPromise.cancel() (described in the docs) seems to be removed and I can't find a method to remove from waiting state. If these two methods would be available, then all this can be added as a one line .kill(jobId) method (from the provider), which, from my point of view, is needed by many users.

Minimal, Working Test code to reproduce the issue.

(An easy to reproduce test case will dramatically decrease the resolution time.)

provider.js

let job = await queue.getJob(8)

job.discard();
job.moveToFailed(new Error('cancelled'), true)
// the two lines above should be replaced by a kill(jobId) method

worker.js

queue.process(Job', 2, __dirname + '/job.js')

queue.on('active', async (job, jobPromise) => {
    console.log("Worker: Active ", job.id)
    var idx = setInterval(async () => {
        isActive = await job.isActive()
        isCompleted = await job.isCompleted()
        isFailed = await job.isFailed()
        console.log("Worker: Checking job ", job.id, isActive, isCompleted, isFailed)
        if (isActive && (isCompleted || isFailed)) {
            console.log("Should kill job", job.id)
            // jobPromise.cancel()
        }
        if (!isActive) {
            console.log("Leaving interval", job.id)
            return clearInterval(idx)
        }
    }, 500)
})

queue.on('global:failed', async (jobId) => {
    console.log("Worker: Job ", jobId, " got globally failed ")
    // Remove ??
    queue.getJob(jobId)
        .then(async (job) => {
            console.log("Worker: Should I remove locally Job ", job.id)
            let waiting = await job.isWaiting()
            console.log("Worker: Job", job.id, waiting, failed)
            if(waiting){
                console.log("Should remove from waiting job", job.id)
                // job.removeWaiting()
            }
        })
        .catch((e) => {
            console.log("Worker:Not able to get job", jobId, e)
        })
})

queue.process(1, __dirname + "/" + 'process.js')

Bull version

3.20.0

Additional information

Thanks a lot !!!

[tjhiggins]

@manast wanted to bump this one since as mentioned the docs seem to be incorrect at least for sandboxed processes
https://github.com/OptimalBits/bull/blob/v3.22.4/REFERENCE.md#events

.on('active', function(job, jobPromise){
  // A job has started. You can use `jobPromise.cancel()`` to abort it.
  jobPromise.cancel()
})

throws error TypeError: job_promise.cancel is not a function

Also would love to know the recommended way to kill processes.

[alolis]

@tjhiggins, @LeoRuspini, you can also try this. Works like a charm for me.

[iflairritesh]

Hey @alolis
Can you please tell how it will work with @nestjs/bull?

[alolis]

Hey @alolis Can you please tell how it will work with @nestjs/bull?

I am afraid I do not have experience with nestjs. However, I have described my whole approach in detail here. It might be helpful to you.