Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug-fix contributions #171

Open
Gollimnar opened this issue Nov 14, 2023 · 1 comment
Open

Misc bug-fix contributions #171

Gollimnar opened this issue Nov 14, 2023 · 1 comment

Comments

@Gollimnar
Copy link

I have a few bug fixes for web/screensaver.js [964affc]:

  • Video error events in pre-player don't log the reason message.
  • Clearing video src attribute triggers phantom error events.
  • prepVideo() doesn't handle missing IDs cleanly.
  • fade/down and wipe/down transitions should be fade/bottom and wipe/bottom, and throw exceptions as a result.
  • drawVideo() transition exceptions freeze the screensaver.
  • IPC 'blankTheScreen' events repeat, causing repeated fadeout effects.

If you're interested, I'll either need permission to open a branch and make a pull request, or possibly just attach the screensaver.js file for review.

@OrangeJedi
Copy link
Owner

This is awesome! Thanks for taking the time to hunt all of those bugs down. I would love the help to improve the project. Previously the best way to contribute has been to fork the repo and open a pull request from the fork (see this link).

I'm excited to see your work. I am working on a release for v1.3.0 right now and these fixes would be great to add in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants