Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying sum memory usage from all workers when parallel runner is used #8018

Open
Wirone opened this issue May 16, 2024 · 1 comment
Open
Labels
kind/enhancement topic/core Core features of Fixer's engine topic/parallel Issues related to parallel runner

Comments

@Wirone
Copy link
Member

Wirone commented May 16, 2024

In #7777 it was omitted on purpose, to not make PR even bigger and harder to grasp. But to display proper info about memory usage we need to pass data about peak memory usage from workers when they're closing and sum it in the main process. Currently parallel runner displays memory usage only from main process, which may be misleading (but is not critical though).

@Wirone Wirone added kind/enhancement topic/core Core features of Fixer's engine topic/parallel Issues related to parallel runner labels May 16, 2024
@keradus
Copy link
Member

keradus commented May 19, 2024

was omitted on purpose

next time, please raise it explicitly as known TODO, rather than waiting for kerad to notice it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement topic/core Core features of Fixer's engine topic/parallel Issues related to parallel runner
Projects
None yet
Development

No branches or pull requests

2 participants