Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasma 6 applets use system icons so missing many icons for applet #3595

Open
CoelacanthusHex opened this issue Nov 14, 2023 · 17 comments
Open

Comments

@CoelacanthusHex
Copy link

  • Distribution (version): Arch Linux
  • Desktop environment: KDE
  • Installing method: Arch Linux Repo

Plasma 6 changed the icon name so it use the wrong icon folder-blue-network for the Bluetooth applet.
https://invent.kde.org/plasma/bluedevil/-/commit/b46b05fdf33ad9e7e32103cd50ce05239c4e8c04

图片

@morganist
Copy link
Contributor

morganist commented Nov 14, 2023 via email

@CoelacanthusHex
Copy link
Author

i think a lot more icons need to be renamed because everything on widgets and panels now uses system icons. keyboard layout icon is wrong, clipboard icon is wrong when i tested it on KDE Neon Unstable (with 2022 version of Papirus from Ubuntu LTS repo).

Maybe some icons need to be re-drawn. e.g. I can't find the symbolic version of configure media-skip-forward media-skip-backward and more.

@CoelacanthusHex CoelacanthusHex changed the title Plasma 6 changed icon name so it detect wrong icon folder-blue-network for bluetooth applet Plasma 6 applets use system icons so missing many icons for applet Nov 14, 2023
@CoelacanthusHex
Copy link
Author

Ok, I can follow this issue to get all the icons we need to be renamed and re-drawn. I will post it here when I finish it.
https://invent.kde.org/plasma/plasma-workspace/-/issues/82

@CoelacanthusHex
Copy link
Author

For backward, do we need to keep the older one? If we need, should we symlink older one to newer, or newer one to older?

@CoelacanthusHex
Copy link
Author

CoelacanthusHex commented Nov 14, 2023

Symlink (existing icon -> symlink name):

  • bluetooth-paired -> network-bluetooth-activated
  • bluetooth-disabled -> network-bluetooth-inactive
  • bluetooth-active -> network-bluetooth; network-wireless-bluetooth
  • smartphoneconnected -> kdeconnect-tray
  • network-wired-offline -> network-wired-unavailable; network-wired-disconnected;
  • network-wired-secure -> network-wired-activated-locked
  • network-wireless-offline -> network-wireless-off
  • network-wireless-signal-excellent -> network-wireless; network-wireless-on
  • airplane-mode -> network-flightmode-on

Make new icons:

  • network-wired-available (an ethernet port with a plus?)
  • network-wired-activated-limited (bright, with a warning)
  • network-limited (transparent, with a warning)
  • network-flightmode-off (transparent plane with a cross)
  • network-wireless-00-limited
  • network-wireless-20-limited
  • network-wireless-40-limited
  • network-wireless-60-limited
  • network-wireless-80-limited
  • network-wireless-100-limited (just add a warning to wifi strength icons)
  • audio-volume-high-danger
  • audio-volume-high-warning (Plasma 6 applets use system icons so missing many icons for applet #3595 (comment))
  • battery-profile-powersave
  • battery-profile-performance
  • preferences-system-disks
  • input-touchscreen
  • input-touchscreen-symbolic
  • bookmarks-bookmarked
  • bookmarks-bookmarked-symbolic
  • preferences-system-bluetooth-symbolic
  • preferences-system-bluetooth-battery-symbolic
  • start-here-kde-symbolic
  • media-skip-forward-symbolic
  • media-skip-backward-symbolic
  • document-open-folder-symbolic
  • preferences-desktop-display-randr-symbolic
  • device-notifier
  • panel-fit-width
  • panel-fit-height
  • applications-all-symbolic
  • kate-symbolic
  • elisa-symbolic
  • klipper-symbolic
  • kmail-symbolic
  • kalarm-symbolic
  • plasmavault
  • plasmavault_error
  • input-keyboard-virtual-show
  • input-keyboard-virtual-hide
  • wallet-closed
  • wallet-open
  • redshift-status-day

Add symlink for -symbolic:

  • battery-profile-powersave
  • battery-profile-performance
  • network-bluetooth-activated
  • network-bluetooth-inactive
  • network-bluetooth
  • network-wireless-bluetooth
  • network-wireless-hotspot
  • network-wireless-acquiring
  • network-wireless-disconnected
  • network-wireless-connected-00
  • network-wireless-connected-25
  • network-wireless-connected-50
  • network-wireless-connected-75
  • network-wireless-connected-100
  • network-wireless-signal-none
  • network-wireless-signal-weak
  • network-wireless-signal-ok
  • network-wireless-signal-good
  • network-wireless-signal-excellent
  • network-wired-activated
  • network-wired-disconnected
  • network-wired-unavailable
  • network-flightmode-on
  • network-flightmode-off
  • network-offline
  • network-connect
  • network-limited
  • nm-device-wired
  • nm-no-connection
  • nm-signal-00
  • nm-signal-25
  • nm-signal-50
  • nm-signal-75
  • nm-signal-100
  • kdeconnect-tray
  • plasmavault
  • redshift-status-on
  • redshift-status-off
  • redshift-status-day
  • update-none
  • update-low
  • update-medium
  • update-high
  • device-notifier
  • camera-ready
  • camera-on
  • camera-off

Rename from non -symbolic in small size (https://invent.kde.org/frameworks/breeze-icons/-/commit/a205857f94906a3a0680cbec87c3d83206b363ef):

  • kdeconnect-symbolic
  • kde-symbolic
  • plasma-symbolic
  • korg-todo-symbolic
  • plasma-browser-integration-symbolic

We leak some weather icon compare to breeze (https://invent.kde.org/frameworks/breeze-icons/-/commit/b6642d281e7ee3e8fd9233bfc808c97c34b199cf)

@SmartFinn
Copy link
Member

I'm shocked that KDE starts using -symbolic icons for panel, instead of icons with KDE Color Scheme support. Looks like the beginning of chaos.

@morganist
Copy link
Contributor

morganist commented Nov 15, 2023

@SmartFinn

instead of icons with KDE Color Scheme support.

does that mean accent-coloured dots inside panel icons wouldn't work in Plasma 6 then?

@SmartFinn
Copy link
Member

@morganist

does that mean accent-coloured dots inside panel icons wouldn't work in Plasma 6 then?

I've not seen yet. I see they have mixed icons that do one job, but in different way.

@morganist
Copy link
Contributor

audio-volume-high-danger
audio-volume-high-warning

274b2f0 ?

@morganist
Copy link
Contributor

morganist commented Nov 16, 2023

In Breeze
audio-volume-high-warning:
volume-warning

audio-volume-high-danger:
volume-danger

@SmartFinn
Copy link
Member

We can use audio-volume-overamplified-symbolic.svg icon with class="warning" and class="error" on the waves.

@morganist
Copy link
Contributor

class="warning" and class="error"

Oh, i forgot about classes in panel icons. That's cool!

@SmartFinn
Copy link
Member

Duplicate the #3606 (comment) here:

The Plasma 6 uses 22px symbolic icons instead of 16px. Papirus icon theme currently doesn't support it. Of course, we can add it symlinks into panel directory, but it not actually the symbolic icons. The symbolic icons use another classes for coloring warning, error, success. See Monochrome icons in our wiki.

@VesperLlama
Copy link

The icons for the power actions (shutdown, restart, logout and sleep) are also showing a blank white icon in the confirmation screen on Plasma 6 Beta 1. They show correctly in the application launcher.

Breeze -
Breeze

Papirus -
Papirus

@morganist
Copy link
Contributor

I'm shocked that KDE starts using -symbolic icons for panel, instead of icons with KDE Color Scheme support. Looks like the beginning of chaos.

@SmartFinn accent colour from kde colour scheme works fine with existing icons!

image

@namesarebloat
Copy link

The icons for the power actions (shutdown, restart, logout and sleep) are also showing a blank white icon in the confirmation screen on Plasma 6 Beta 1. They show correctly in the application launcher.

That has been fixed by KDE. Non monochrome icons now show up correctly on the lockscreen. However, I personally would prefer monochrome/symbolic icons for both the application launcher and lockscreen, but maybe that's just me.

morganist added a commit that referenced this issue Apr 24, 2024
… icon symlink for fallback; revork of 22px & 24px xpfm-brightness-lcd #3663 #3595
@morganist morganist pinned this issue Apr 24, 2024
@morganist
Copy link
Contributor

@CoelacanthusHex From now on, I'll be updating your #3595 (comment) as a to-do list to catch up with Breeze icons I've found... a bunch more.

morganist added a commit that referenced this issue Apr 24, 2024
morganist added a commit that referenced this issue Apr 24, 2024
… nobody knows what it's for, and it interferes with new kwalletmanager icons #3663 #3595
morganist added a commit that referenced this issue May 15, 2024
morganist added a commit that referenced this issue May 15, 2024
morganist added a commit that referenced this issue May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants