Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trade function bug #6216

Open
2 tasks done
jonny199292 opened this issue May 9, 2023 · 0 comments · May be fixed by #7572
Open
2 tasks done

Trade function bug #6216

jonny199292 opened this issue May 9, 2023 · 0 comments · May be fixed by #7572
Labels
bug Something isn't working

Comments

@jonny199292
Copy link

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

How is Path of Building expected to behave?

i've searched for 10c jewels and after i searched all with automate function i check include enchants and this pops out

How does Path of Building behave?

gives a error

How to reproduce the issue

after i seached every jewel with 10c tag and check include enchants pops out this error.

Character build code

build https://pobb.in/RoNRAe3qMtoA

Screenshots

image
@jonny199292 jonny199292 added the bug Something isn't working label May 9, 2023
teroshan added a commit to teroshan/PathOfBuilding that referenced this issue Apr 14, 2024
@teroshan
Fix error when toggling 'Include Enchants' in trader
99b7524 
It seems like the UpdateControlsWithItems() has been refactored right
when this checkbox has been added, changing the expected argument
format.

No other callers use the obsolete arguments.

Fixes PathOfBuildingCommunity#6216
@teroshan teroshan linked a pull request Apr 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error when toggling 'Include Enchants' checkbox in trader teroshan/PathOfBuilding
1 participant
@jonny199292