Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full DPS calculation of Spark should adjust for hit rate #7612

Open
1 task done
lextra2 opened this issue May 3, 2024 · 3 comments
Open
1 task done

Full DPS calculation of Spark should adjust for hit rate #7612

lextra2 opened this issue May 3, 2024 · 3 comments
Labels
enhancement New feature, calculation, or mod

Comments

@lextra2
Copy link

lextra2 commented May 3, 2024

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

Is your feature request related to a problem?

A Spark projectile can hit once every 0.66 seconds, per cast.

The Full DPS calculation does not adjust for that (instead, it assumes that there is only one hit per second, per cast).

Describe the solution you'd like

An easy fix would be to give Spark a 1.34x DPS multiplier.

Describe alternatives you've considered

Using 34% more projectile damage in the custom mod field

@lextra2 lextra2 added the enhancement New feature, calculation, or mod label May 3, 2024
@Regisle
Copy link
Member

Regisle commented May 3, 2024

instead, it assumes that there is only one hit per second, per cast

PoB does not actually even do that, it only assumes 1 hit per cast

The projectiles traveling randomly and the size of the enemy/arena play a large factor, and thus there are too many assumptions that need to be made for PoB to calculate this, the best option is to determine for your setup how many times you think it hits and then either use a custom mod, or full dps count to adjust for that

(also better than using a custom mod for "more projectile damage" just use "more dps" as that is better for factoring in ailments etc)

@Selmafudd
Copy link

You can setup Spark's full dps already.

On Calc tab check Spark's skill duration, divide that by 0.66 seconds and round down, this value is your theoretical max hits from a single cast of spark .
On Skill tab check Include in Full DPS for spark and in the count field enter the value above.

@lextra2
Copy link
Author

lextra2 commented May 3, 2024

(also better than using a custom mod for "more projectile damage" just use "more dps" as that is better for factoring in ailments etc)

Oh, neat. I was wondering if there was such a generic mod, thanks.

You can setup Spark's full dps already.

On Calc tab check Spark's skill duration, divide that by 0.66 seconds and round down, this value is your theoretical max hits from a single cast of spark . On Skill tab check Include in Full DPS for spark and in the count field enter the value above.

I'll try that later. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

No branches or pull requests

3 participants