Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilteredReactiveRetryPolicy with ExceptionPopagationPolicy #659

Open
AmanKamani opened this issue Dec 30, 2023 · 1 comment
Open

FilteredReactiveRetryPolicy with ExceptionPopagationPolicy #659

AmanKamani opened this issue Dec 30, 2023 · 1 comment

Comments

@AmanKamani
Copy link

FilteredReactiveRetryPolicy doesn't override the exceptionPropagationPolicy from ReactiveRetryPolicy. So, either it should override that or use the exceptionPropagationPolicy from the RetryPolicy which it takes as an argument of constructor.

Now, Let's say we are passing BasicReactiveRetryPolicy (with ExceptionPropagationPolicy as UNWRAP) while creating instance for FilteredReactiveRetryPolicy. When Retries are exhuasted, that time exceptionPropagationPolicy flag will be NONE. So, it won't unwrap the OutOfRetryException. So, we need to override the exceptionPropagationPolicy in FilteredReactiveRetryPolicy.

@AmanKamani
Copy link
Author

@kptfh I have raised PR for this: #658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant