FEATURE: Video clip playback

[davepl]

This is a juicy feature for anyone up to the task! I have a client side program called videoserver.py that's checked into the samples folder, and the matrix looks really cool playing certain videos, like a fireplace loop.

It woud be nice if we had an effect that played a YouTube video. There are a number of code samplers on Github for playing video, but not sure if anything exists for YouTube specifically.

Short of that goal, being able to play a simple mpeg video file that we embed would also be good.

[robertlipe]

One of these four statements is an untruth.

NightDriverStrip/src/network.cpp

Line 591 in ff1e7a3

// The thread which serves requests for color data on port 49153

IMO, we should hoist that and ,

NightDriverStrip/src/main.cpp

Line 351 in ff1e7a3

g_ptrSystem->SetupSocketServer(49152, NUM_LEDS); // $C000 is free RAM on the C64, fwiw!

into a single table to be consulted for such things. (It seems like there's another port number hardcoded somewhere....The telnet server?)

I don't even care if they're dynamically changeable or in a .ini file or whatever - even just a network_config.h with some # defines would be fine, IMO.

I'll do it, if it's agreed that's OK.

[robertlipe]

See associated PR #543

[robertlipe]

No agreement, but let's kick
#355
around a little instead of scattering port numbers all over the tree.

I can't find the '23' for the telnet port number for the debug server.

Edit: it's basically hardcoded (#define TELNET_PORT 23) and it's in the hidden part of the source that's duplicated per build.

./.pio/libdeps/demo/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/ledstrip_feather/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/m5demo/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/m5plusdemo/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/panlee/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/ledstrip/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/umbrella/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/generic/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/spectrum/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/xmastrees/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/chieftain/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/mesmerizer/RemoteDebug/src/RemoteDebugCfg.h
./.pio/libdeps/heltecdemo/RemoteDebug/src/RemoteDebugCfg.h
➜ nightdriverstrip git:(ports) ✗

[rbergen]

I'd not say it's hidden, but rather that it's a dependency. And yes, those can have defines of their own. Interestingly enough, the version of RemoteDebug we use is a PSL fork, which means we could update it to source its port number from another place.

[rbergen]

I just noticed this:

See associated PR #543

I think that's actually #549?

[robertlipe]

It's both. The feature was implemented in 543. The related issue brought up in this thread at #355 (comment) was fixed by #549

[rbergen]

Was the feature implemented in #543? This issue talks about YouTube videos or embedded MPEGs. #543 provides an implementation for animated GIFs.