New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen 9 TMs missing #1029
Comments
I was looking into this too. I just noticed that even though I can check pokemons' moves, and they give me the url to fetch the details of each move, the machine array is empty for some of them. EDIT: Thinking a bit more about the issue, if we could just search the machines by name, for example: "https://pokeapi.co/api/v2/machine/trailblaze", we could try to workaround the missing information in the other endpoints. Cause I feel like it's going to be hard to loop though the 1600 moves that the api has, only to check if the name is the one that you're looking. And if that the endpoint for the machines could be fetched with the name, might as well change the other endpoints so they could be fetched by names too. |
Hi, did you check the actual CSV data? We might lack it, so we would need someone to fill it in. |
@Naramsim where can I check? I'll try to support if I can :) |
The data itself for machines is within /data/v2/csv/machines.csv as it is seen there, it only goes up to sword and shield. not even sword shield dlc TMs, if there are any, are in the data |
@GreatNovaDragon ok, yeah I can see that the highest the version_group_id goes is 20. If I were to propose an updated csv with scarlet-violet machines, do I have to upload it somewhere and send it here? (I've recently started learning web development, so I'm a bit lost) |
I'm not exactly sure how to explain the github pull request workflow to a new person, but the process is to fork the gitrepo, do your changes, and then do a pull request of your fork to the main repo. |
I'll try to investigate on the matter, and see what I can do :) Thanks for the help |
Hi, I am trying to use your API but it seems tms from gen9 aren't there, when will this be added?
The text was updated successfully, but these errors were encountered: