Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Nullable Reference Types #54

Open
vany0114 opened this issue Nov 28, 2019 · 1 comment
Open

Adopt Nullable Reference Types #54

vany0114 opened this issue Nov 28, 2019 · 1 comment

Comments

@vany0114
Copy link
Member

Throwing this here to take into consideration, according to Microsoft, we should consider adopting NRT by next year:
https://devblogs.microsoft.com/dotnet/embracing-nullable-reference-types/

There are some caveats tho regarding C# 8 and multitargeting that I'm not sure if we have to care about (I have to dig into it) but as I said, just to consider it, let me know your thoughts @reisenberger please.

@reisenberger
Copy link
Member

Yes, it would be good for any library like Simmy to adopt this by Nov 2020.

Given Simmy extends Polly, it probably makes sense to implement nullable reference types for Simmy after it has been implemented for Polly, as some settings for Simmy will 'flow' from attribution/NRT-decisions made on the external surface of Polly.

caveats regarding C# 8 and multitargeting that I'm not sure if we have to care about

Where we need to apply attributes that are not part of a given target by default, we can probably adopt the strategy that those targets manually include the attribute code (probably the same thing you have read about).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants