PS 8.1.5 requires PHP 8.0?

[ChillCode]

Hi

Does PS 8.1.5 require PHP 8.x ?

str_contains added in PHP 8:

#35790

Not sure what is going here, but the solution from a QA member is to upgrade to PHP 8.

#35870

If so, should be changed on requirements page, and clearly state that upgrades from previous versions are not possible anymore (using autoupgrade) since PS 1.7.x is not compatible with PHP 8.

[matks]

Hello @ChillCode as far as we know PS 8.1.5 works with PHP 7.2 to PHP 8.1

If you have found a situation where PS 8.1.5 cannot run with PHP 7.2, the solution is not change the requirements page or the documentation. The solution is to fix the bug.

PrestaShop 8.1.5 uses Symfony 4.4.50 . The class you mention Symfony\Component\Finder\Iterator\ExcludeDirectoryFilterIterator indeed contains a call to php function str_contains which was introduced in PHP8.

Symfony 4.4.50 is marked to require PHP >=7.1.3

So it is possible - it needs confirmation - that you found a bug in Symfony 4.4.50, that is being used in PS 8.1.5, and the bug is that Symfony 4.4.50 is not compatible with PHP7.

[matks]

Symfony Finder 4.3 https://github.com/symfony/finder/blob/4.3/Iterator/ExcludeDirectoryFilterIterator.php

no str_contains

Symfony Finder 4.4 https://github.com/symfony/finder/blob/4.4/Iterator/ExcludeDirectoryFilterIterator.php

the str_contains has been added

the composer.json of both versions states it's compatible with php 7.1 and above
https://github.com/symfony/finder/blob/4.4/composer.json
https://github.com/symfony/finder/blob/4.3/composer.json

[matks]

Well looks like it was kinda assumed 😛 symfony/finder@030c59d

[matks]

Oh, no I got it!

They use str_contains because symfony/finder also requires symfony/polyfill-php80 which is supposed to give you the ability to use str_contains even if you are running php7

@ChillCode can you check if you have symfony/polyfill-php80 and if yes, why it does not work for you?

[ChillCode]

Hi @matks

I just read #35790 and saw that function was called (nice method btw) then I read the recommendation for #35870 so I thought something changed.

Searching at symfony repo people are using polyfills to solve the issue.

[ChillCode]

At my end symfony/polyfill-php80 is loaded, just updated a site last week and did not face that issue.

Thanks for the clarification @matks

[matks]

Mmmm sometimes there are composer loading issues, some cache clearing problems can happen, or some PHP caching systems (like opcache)

So maybe you were unlucky 😅 last time but lucky this time

[LaurynasLTU]

8.0.5 presta with php 7.4 - many modules from 1.7, 8.x
8.1 presta with php 7.4 - a lot less modules
or
8.1 presta with php 8.1 - only new 1 month modules and many deprecated functions error messages, and bugs

90 percent of the presta 1.7, 8.0 versions of the module work with php 7.4 version, so now, at least for a year, there will be no point in using php 8.1 version. I'm using presta 8 with some modules that are for presta 1.7 and I'm glad they work. Although the downside is that with php 8.1, presta 8 works much faster, but more server resources are needed.

In general, presta 1.6 runs the fastest and uses the least amount of server resources.

[ChillCode]

Well, you right, I saw lately some of those issues came from third-party modules (some from MP) that have a mess with compatibility and are interfering with PrestaShop composer after users upgrade to 8.1 and keep PHP 7.4 and that's why composer don't load all required polyfills/classes correctly, those modules require PHP 8.