Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on the migrated Attributes pages #35591

Open
8 of 20 tasks
MatShir opened this issue Mar 8, 2024 · 0 comments · May be fixed by #36068
Open
8 of 20 tasks

Regression on the migrated Attributes pages #35591

MatShir opened this issue Mar 8, 2024 · 0 comments · May be fixed by #36068
Assignees
Labels
Attributes Label: Which BO under menu is concerned Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on Verified The issue has been reproduced

Comments

@MatShir
Copy link
Contributor

MatShir commented Mar 8, 2024

Tested on PR migration

  • B1: Wrong color input display
  • B2: Can't add attribute value from the list
  • B3: Attribute value list doesn't adapt itself if the attribute type changes
  • B4: SQL query not working
  • B5: Product doesn't adapt when the type of the attribute group changes
  • B6: Can't add texture This one is handled by Add texture in attribute color #36068
  • B7: Wrong wording titlte
  • B8: Missing wording and catch the error for the public name missing
  • B9: Can't click on the row to view the attribut value list
  • B10: Attribute group list is not by default sorted by position

I have found a few issues.

Bug 1

The block Color used to displayed correctly. Now there's one line in the input instead of the chosen color.
Before:
Screenshot 2024-03-07 at 14 49 33
After:
Screenshot 2024-03-07 at 14 48 57

  • Fixed ?

Bug 2

On the Attributes pages, I could chose to Add new attribute or Add a new value. Now I only have one choice.
Before:
Screenshot 2024-03-07 at 14 53 36
After:
Screenshot 2024-03-07 at 14 53 42

  • Fixed ?

Bug 3

When I add a new value and change the attribute group, the inputs for that attribute are not displayed. In my case, I have to go to my Color attribute and edit it to add a color manually.
Steps to reproduce :

  • Go to BO > Attributes page > View Paper Type
  • Click Add new value button
  • In Attribute group > Change it to Color
  • The inputs for the color attributes are not automatically displayed ❌

Same case the other way around.

  • Go to BO > Attributes page > View Color
  • Click Add new value button
  • In Attribute group > Change it to Dimension
  • The inputs for the color attributes are not automatically removed ❌
Screen.Recording.2024-03-07.at.15.03.16.mov
  • Fixed ?

Bug 4

The options Show SQL Query and Export to SQL manager do not work as expected. The query is different compared to the old page and the export gives a Bad Query.
Before:
Screenshot 2024-03-07 at 15 33 12
After:
Screenshot 2024-03-07 at 15 31 32

  • Fixed ?

Bug 5

When I edit the Attribute Color to a Dropdown list Attribute type, it won't refresh my page with the right Attribute Type. On old page, it was well removed.
I tried clearing cache from PS and browser.

Steps to reproduce :

  • Edit Color Attribute
  • Choose Attribute type = Drop-down list > Save
  • Click View Color
  • See all the Color column still displayed on the list
Screen.Recording.2024-03-07.at.15.47.33.mov

The issue is also present on the Product page. When I create a product with combinations, the attributes Color is displayed with a color, when I deleted it. (this last issue is not related to the PR)
Screenshot 2024-03-07 at 15 52 15

  • Fixed ?

Bug 6

The texture can't be added. The color Black is automatically added.

Screen.Recording.2024-03-07.at.16.08.16.mov
  • Fixed ?

Bug 7

I have reproduced all of the issues mentioned by @Hlavtox #35270 (review)
Indeed, when I edit an attribute value, the title of the page is misleading.
In my case, it says Editing attribute Gray. It should say Editing attribute value Gray or Editing value Gray.
There's no reference on the old page, as it only says "Attributes".

Screenshot 2024-03-07 at 15 08 14
  • Fixed ?

Bug 8

If you save a new attribute without Public name, you will have an exception.

Screenshot 2024-03-07 at 15 18 39
  • Fixed ?

Bug 9

Attribute list is not clickable, you have to click on the small View button to get to the list of values. On the old page, you could click on the name AND on the View button.

Same issue with Attributes values. you have to click on the Edit button to edit your value. On the old page, you could click on the name AND on the Edit button.

Screen.Recording.2024-03-08.at.16.25.12.mov
  • Fixed ?

Bug10

For some reason, when I open a list of attribute values, it automatically opens "rearrange" mode. It doesn't happen in attribute list.

Need to adapt the attribut group list

Screenshot 2024-03-07 at 15 58 35
  • Fixed ?

Not really a bug but feedbacks

feedback 1

There's an option to Import your Attributes and attributes values. But in the import of PrestaShop, you have to import Products with Attributes in order to get the attributes created. So I think this is misleading and should not be an option. There's no Import type Attributes.

Screenshot 2024-03-07 at 15 24 53

feedback 2


It is not possible to filter by Position anymore. #11217 (comment)
Before:
Screenshot 2024-03-07 at 15 57 20

After:
Screenshot 2024-03-07 at 15 57 03

@MatShir comment: To order you have to select rearrange

feedback 3


The block URL is misleading. It should not say URL. I'm not sure what it was meant to say 🤔

Screenshot 2024-03-07 at 16 09 54

Regarding the block Meta Title, I'm not sure how to use it.
I added an element, but in the FO, I don't see it anywhere.

Screenshot 2024-03-07 at 16 13 38

@MatShir comment: You need to insert a path, maybe to check with the content team. It will be a bonus on this PR (not blocking)

Waiting for your feedback 😃
Thanks!

@MatShir MatShir changed the title Regression on the migrated page Regression on the migrated Attributes pages Mar 8, 2024
@MatShir MatShir added Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Attributes Label: Which BO under menu is concerned Ready Status: Issue is ready to be worked on Verified The issue has been reproduced labels Mar 8, 2024
@nicosomb nicosomb self-assigned this Mar 14, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 17, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 22, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 23, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 23, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 23, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 25, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 25, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 25, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 25, 2024
@MatShir MatShir assigned tleon and unassigned nicosomb May 2, 2024
@tleon tleon linked a pull request May 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attributes Label: Which BO under menu is concerned Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on Verified The issue has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants