Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation and README file to linked list folder, minor fixes to README #456

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kseniavelichko
Copy link

@kseniavelichko kseniavelichko commented Oct 1, 2023

Fixed broken Primorial link in the README,
fixed minor style discrepancies in the README,
added a README file to the linked list folder,
and added documentation to the doubly linked list file in the form of a short description and minor comments explaining the code.

Closes #455

Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Inactive label Mar 13, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted. You can update .gitignore to add an entry for .DS_Store

@stale stale bot removed the Inactive label Apr 10, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of scope for this PR. If you like you can create a new PR to suggest adding this GitHub action.

@@ -178,6 +178,7 @@ SinglyLinkedList<T>::SinglyLinkedList() {
/*
Destructor
----------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank link can be removed.

@faheel
Copy link
Member

faheel commented Apr 10, 2024

@kseniavelichko Thanks for improving the documentation! Once the above comments are resolved this is good to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lacking documentation in linked list and other minor changes in the README
2 participants