Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dag longest path functions to rustworkx-core #1168

Closed
Tracked by #1121
mtreinish opened this issue Apr 19, 2024 · 2 comments
Closed
Tracked by #1121

Move dag longest path functions to rustworkx-core #1168

mtreinish opened this issue Apr 19, 2024 · 2 comments
Assignees
Labels
rustworkx-core Issues tracking adding functionality to rustworkx-core

Comments

@mtreinish
Copy link
Member

The dag longest path family of functions:

  • dag_longest_path
  • dag_longest_path_length
  • dag_weighted_longest_path
  • dag_weighted_longest_path_length

Are all built using the following rust module:

https://github.com/Qiskit/rustworkx/blob/ab93329be6d8aaccb6c090f4b3ab6f9540ee8114/src/dag_algo/longest_path.rs

and are only exposed via the Python interface currently. We should move these to rustworkx-core so that Rust users can take advantage of them. Realistically probably adding the longest_path module is sufficient as the pyfunctions currently exposed are just an interface layer for Python and don't any extra value for rust consumers.

@mtreinish mtreinish added the rustworkx-core Issues tracking adding functionality to rustworkx-core label Apr 19, 2024
@henryzou50
Copy link
Contributor

I am interested in this issue. Can you assign this to me?

@mtreinish
Copy link
Member Author

Fixed by #1192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rustworkx-core Issues tracking adding functionality to rustworkx-core
Projects
None yet
Development

No branches or pull requests

2 participants