Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rename socials to connections #106

Open
oSumAtrIX opened this issue Oct 15, 2023 · 3 comments · May be fixed by #142
Open

feat: Rename socials to connections #106

oSumAtrIX opened this issue Oct 15, 2023 · 3 comments · May be fixed by #142
Assignees
@alexandreteles
Labels
good first issue Good for newcomers modification Modification of an existing feature, for example refactor

Comments

@oSumAtrIX
Copy link
Member

Issue

Currently, we refer to the links endpoints as socials, but they turned out to be more than that, involving various links.

Solution

Rename socials to connections or links as a generalization.

Additional context

This may be considered a breaking change so incrementing the API version may be necessary.
@alexandreteles alexandreteles self-assigned this Oct 19, 2023
@alexandreteles alexandreteles added good first issue Good for newcomers modification Modification of an existing feature, for example refactor labels Oct 19, 2023
@Ushie
Copy link
Member

Ushie commented Nov 27, 2023

Has this been resolved in the feat/fly branch? or is it still up for grabs

@alexandreteles
Copy link
Member

Still up.

@validcube validcube linked a pull request Dec 17, 2023 that will close this issue
Open
@Ushie
Copy link
Member

Ushie commented Dec 17, 2023

@ReVanced/infrastructure Maybe make a v3 milestone label/project for this repo and assign this to it?

@alexandreteles alexandreteles linked a pull request Jan 16, 2024 that will close this issue
refactor!: rename socials to connections #142
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandreteles alexandreteles

Labels
good first issue Good for newcomers modification Modification of an existing feature, for example refactor
Projects
Development of ReVanced
Status: 🏗 In progress
Milestone
No milestone
3 participants
@alexandreteles @oSumAtrIX @Ushie