Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Useragent handler for announcements #136

Open
oSumAtrIX opened this issue Dec 7, 2023 · 2 comments
Open

feat: Useragent handler for announcements #136

oSumAtrIX opened this issue Dec 7, 2023 · 2 comments
Assignees
@alexandreteles
Labels
modification Modification of an existing feature, for example refactor

Comments

@oSumAtrIX
Copy link
Member

Issue

Currently, every announcement consumer receives announcements. This is impractical, considering we may want to make announcements for specific users.

Solution

Add a handler for the user agent. Based on the user agent, the announcement will be supplied or not.
@alexandreteles
Copy link
Member

Can you explain it a little better? What architecture do you have in mind?

@alexandreteles alexandreteles added the modification Modification of an existing feature, for example refactor label Dec 10, 2023
@oSumAtrIX
Copy link
Member Author

The implementation itself is not in focus. The idea is that we can send announcements based on the user agent. This would allow us to show announcements to specific groups of clients. Maybe this can be specified when creating a new announcement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandreteles alexandreteles

Labels
modification Modification of an existing feature, for example refactor
Projects
Development of ReVanced
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexandreteles @oSumAtrIX