Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release advanced patch option types #26

Open
4 tasks done
Ushie opened this issue Nov 19, 2023 · 8 comments
Open
4 tasks done

feat: release advanced patch option types #26

Ushie opened this issue Nov 19, 2023 · 8 comments
Assignees

Comments

@Ushie
Copy link
Member

Ushie commented Nov 19, 2023

Feature description

Introduce Patch Option Types such as Color, which extend on ReVanced Patcher types

Motivation

The ability to use the best-fitting UI for patch options in GUI frontends, while keeping only the necessary types in ReVanced Patcher which has refused to implement these types

Additional context

Perhaps this can be moved to ReVanced Library

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 19, 2023

The option types should be structured in it's own Gradle subproject. The subproject is to be then released as a maven package. Patches then have to shade the classes, otherwise they will not work outside of ReVanced Manager because the types would be missing

@Ushie
Copy link
Member Author

Ushie commented Jan 10, 2024

This can be moved to the ReVanced Library repository @oSumAtrIX

@oSumAtrIX
Copy link
Member

Please open a new issue, this one specifically requests ReVanced Manager patch options and not general advanced types

@Ushie Ushie changed the title feat: release ReVanced Manager flavored patch options types feat: release advanced patch option types Jan 10, 2024
@Ushie
Copy link
Member Author

Ushie commented Jan 10, 2024

No longer an issue, solved

@oSumAtrIX
Copy link
Member

Which abstract types are needed?

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-manager Jan 10, 2024
@Ushie
Copy link
Member Author

Ushie commented Jan 10, 2024

  • File
  • Directory
  • Color
  • General types like Number

Those are the ones I can state of the top of my head, @PalmDevs may have more to add

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jan 10, 2024

Former 3 will abstract String but former 2 can abstract File. For the last one, decimal and integral numbers are supported as primitive types already.

@PalmDevs
Copy link
Member

Also include resource name which will abstract String. Eg. @android:color/black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants