Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command operation bug #100

Open
capticka opened this issue May 8, 2024 · 6 comments
Open

Command operation bug #100

capticka opened this issue May 8, 2024 · 6 comments
Assignees

Comments

@capticka
Copy link

capticka commented May 8, 2024

Hello, again.
I am telling you that there is an error in KeyPerSecond.
There is a command here, but it doesn't work well.
I reset the total, but the stats are reset, and I reset the stats again, but the total is reset.
Also, even if you press Ctrl + R for both total initialization and stat initialization, only one of the total or stats will be reset, and no matter how many times you press it again, it will not be reset.
That was a bit long. Please fix it.
V8.9

@RoanH
Copy link
Owner

RoanH commented May 25, 2024

Hello, I feel like there are multiple issues in this report:

  1. There is a command here, but it doesn't work well.
    The reset totals command Ctrl+I is perhaps named a bit misleading since it predates the total panel, this command only resets the total number of hits for each key panel (so not the total panel). I may rename it for the next release.
  2. I reset the total, but the stats are reset
    Stats refers to the aggregate panels, so MAX/AVG/KPS/TOT/LST, I can't reproduce these being reset by the reset totals command.
  3. and I reset the stats again, but the total is reset.
    The TOT panel is one of the stat panels together with MAX/AVG/KPS/LST, so this is intentional.
  4. Also, even if you press Ctrl + R for both total initialization and stat initialization, only one of the total or stats will be reset, and no matter how many times you press it again, it will not be reset.
    I can't reproduce this, all of the key panels and AVG/MAX/KPS/LST/TOT get reset to 0 if I run Ctrl+R.

Please let me know if I misunderstood something or if anything is unclear.

@RoanH RoanH self-assigned this May 25, 2024
@RoanH RoanH added question blocked Issues waiting for more information. labels May 25, 2024
@capticka
Copy link
Author

Why do I reset only the panels such as KPS, MAX, AVG, TOT, etc. even if I set the Reset stats and Reset totals commands with Ctrl + R?

@RoanH
Copy link
Owner

RoanH commented May 26, 2024

Ctrl+R is intended to reload the entire configuration, it resetting the counts is just a side effect. If you have automatic stats saving on exit and/or stats loading on launch enabled, then it won't even reset the stats at all since they'll be restored when you reload the config.

@capticka
Copy link
Author

By any chance, can't this program execute two commands with the same command?

@RoanH
Copy link
Owner

RoanH commented May 30, 2024

Ah, that's an interesting use case. Setting the same key combination for different commands will indeed cause one of them to not execute, specifically, the precedence order is reset stats > exit > reset totals > hide > pause > reload. I suppose that since the key combinations are configurable now it would be better allow them to be bound more than once, I'll pick that up for the next release.

@RoanH RoanH added enhancement and removed blocked Issues waiting for more information. question labels May 30, 2024
@capticka
Copy link
Author

Oh, I think that was the problem. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants