Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make InPlaceInit compatible with Arc #1079

Open
y86-dev opened this issue May 4, 2024 · 1 comment
Open

make InPlaceInit compatible with Arc #1079

y86-dev opened this issue May 4, 2024 · 1 comment
Labels
good first issue Good for newcomers • lib Related to the `rust/` library.

Comments

@y86-dev
Copy link
Collaborator

y86-dev commented May 4, 2024

Currently InPlaceInit is not implemented for Arc, because pin_init() returns a Pin<Self>. But Arc implicitly pins its contents, so the return type should actually be just Self.

Add an associated type to InPlaceInit that is then used as the return type. Also implement InPlaceInit for Arc and ListArc if available 1.


This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes, to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and so on. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel. Please do not take it if you do not plan to make other contributions to the kernel.

Footnotes

  1. Note that currently only v1 of the list abstractions exist, so ListArc might not be upstreamed.

@y86-dev y86-dev added • lib Related to the `rust/` library. good first issue Good for newcomers labels May 4, 2024
@ellcs
Copy link

ellcs commented May 20, 2024

Hi! I am new to the kernel development, and this looks doable to me. So I work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers • lib Related to the `rust/` library.
Development

No branches or pull requests

2 participants