Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify license #5130

Open
h7kanna opened this issue Dec 13, 2023 · 3 comments · May be fixed by #5131
Open

Clarify license #5130

h7kanna opened this issue Dec 13, 2023 · 3 comments · May be fixed by #5131

Comments

@h7kanna
Copy link

h7kanna commented Dec 13, 2023

Summary

RustPython uses https://github.com/mhogrefe/malachite which is licensed as LGPL.
This does impact the licensing of projects(non-open-source) that embed RustPython.
Do you think this should be mentioned in the documentation?
Just the LICENSE is not clear enough.

Details
@youknowone
Copy link
Member

Thank you, that's a good point.

I think we still can support num-bigint instead of malachite-bigint without code change. (except for import)
We need to maintain feature flag for that and documentation.

@h7kanna
Copy link
Author

h7kanna commented Dec 13, 2023

Oh, I could work on adding the feature flag for it then.
Just started looking at this project. Will figure out the 'num-bigint' dep part.

@h7kanna
Copy link
Author

h7kanna commented Dec 15, 2023 •
edited

It seems like the Parser's format crate makes the malachite a hard dependency
https://github.com/RustPython/Parser/blob/main/format/Cargo.toml

This was referenced Dec 16, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added num/malachite-bigint features h7kanna/RustPython
2 participants
@youknowone @h7kanna