CDN: source map no longer applied expectedly since 1.120 with Chromium browsers #4035
Comments
|
I assume that "locally built" means built with the But that difference is caused by differences between the public and the SAP internal build. Internally, we merge a few legacy sources into the build result for sap.ui.core (and others). Those sources are legacy and have been deprecated before UI5 went open source. We therefore decided to omit them from the OpenUI5 repository and only kept them internally for compatibility reasons. I can confirm that the source maps work as expected for 1.119.0 and don't work as expected in 1.120.0. But I could not easily confirm that source maps work when build locally. Only when I used Another observation: with Safari, source maps even work in 1.120 when loaded from the CDN. |
|
I can confirm also that the source maps work with Firefox in UI5 1.120 too. |
boghyon
changed the title
|
Hi @boghyon , |
… map If a resource features an empty source map (which is not the same as having no source map), the bundle's source map generation needs to handle this differently from cases where mappings exist. It must not prefix the empty mapping with a string "AAAA," since the danglíng comma will result in a corrupt source map. However, it should still add the mapping for the first line/column "AAAA". Otherwise the source map of the preceding module in the bundle would be applied. Resolves the root cause of SAP/openui5#4035 DINC0139775
|
I created a fix on UI5 Tooling side: SAP/ui5-builder#1014 For sap.ui.core this is ultimately caused the added handling for input source maps (since |
… map If a resource features an empty source map (which is not the same as having no source map), the bundle's source map generation needs to handle this differently from cases where mappings exist. It must not prefix the empty mapping with a string "AAAA," since the danglíng comma will result in a corrupt source map. However, it should still add the mapping for the first line/column "AAAA". Otherwise the source map of the preceding module in the bundle would be applied. Resolves the root cause of SAP/openui5#4035 DINC0139775
… map If a resource features an empty source map (which is not the same as having no source map), the bundle's source map generation needs to handle this differently from cases where mappings exist. It must not prefix the empty mapping with a string "AAAA," since the danglíng comma will result in a corrupt source map. However, it should still add the mapping for the first line/column "AAAA". Otherwise the source map of the preceding module in the bundle would be applied. Resolves the root cause of SAP/openui5#4035 DINC0139775
…ource map If a resource features an empty source map (which is not the same as having no source map), the bundle's source map generation needs to handle this differently from cases where mappings exist. It must not prefix the empty mapping with a string "AAAA," since the danglíng comma will result in a corrupt source map. However, it should still add the mapping for the first line/column "AAAA". Otherwise the source map of the preceding module in the bundle would be applied. Resolves the root cause of SAP/openui5#4035 DINC0139775 (cherry picked from commit 1228db7)
…ource map If a resource features an empty source map (which is not the same as having no source map), the bundle's source map generation needs to handle this differently from cases where mappings exist. It must not prefix the empty mapping with a string "AAAA," since the danglíng comma will result in a corrupt source map. However, it should still add the mapping for the first line/column "AAAA". Otherwise the source map of the preceding module in the bundle would be applied. Resolves the root cause of SAP/openui5#4035 DINC0139775 (cherry picked from commit 1228db7)
|
Fix in UI5 Tooling got released with All affected and currently maintained UI5 code lines have been updated to use this version for their next patch release, as well as the next UI5 minor release. Therefore closing this issue for the time being. Thanks for spotting this! |
URL (minimal example if possible)
https://embed.plnkr.co/NKOfisfY7w0MOiX8?show=manifest.json,preview:?sap-ui-xx-componentPreload=off
Steps to reproduce the problem
manifest.jsonsection/sap.ui5/commands/MyRefresh/shortcut:"F5"-->"F5 "which is not an allowed character there.What is the expected result?
The error in the console includes a link to the place via the source map where the Error was thrown. In the sample above, the link should lead to the
ShortcutHelper-dbg.js. This is currently the case until UI5 1.119.What happens instead?
The error shows a link to the
library-preload.jsinstead since UI5 1.120, but only if the framework is bootstrapped from the CDN URL. Building the UI5 SDK from rel-1.120 and bootstrapping fromhttp://localhost:8000/resources/sap-ui-core.jsshows theShortcutHelper-dbg.jslink in the console expectedly.Any other information? (attach screenshot if possible)
The
library-preload.js.mapcontent from the CDN seems to differ from the locally builtlibrary-preload.js.map.The text was updated successfully, but these errors were encountered: