Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Doc for calculateStartDate in SinglePlanningCalendarView #4045

Closed
signix opened this issue May 7, 2024 · 3 comments
Closed

JS Doc for calculateStartDate in SinglePlanningCalendarView #4045

signix opened this issue May 7, 2024 · 3 comments

Comments

@signix
Copy link

signix commented May 7, 2024

OpenUI5 version:

The jsdoc of method calculateStartDate in file src/sap.m/src/sap/m/SinglePlanningCalendarView.js does not indicate a return type.
Should it include
* @return {object} the startDate of the view
as we can see in the implementations (SinglePlanningCalendarWorkWeekView, SinglePlanningCalendarWorkWeekView or SinglePlanningCalendarMonthView) ?

Without this the typescript function is expected to return void.

I can add a PR if this is the case.

Thank you

@DonkeyCo
Copy link
Member

DonkeyCo commented May 8, 2024

I've opened an internal incident (DINC0144944) for this problem. The colleagues will have a look and will get back to you

@didip1000
Copy link
Contributor

Hey @signix,

Thanks for sharing your finding, the issue was fixed with the commit linked above and will be available in UI5 version 1.125.

Best,
Diana

@signix
Copy link
Author

signix commented May 22, 2024

Thank you for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants