Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Cancel Buttons have Border around them in 1.119 and 1.120 #4046

Open
ac1058 opened this issue May 10, 2024 · 1 comment
Open

Dialog Cancel Buttons have Border around them in 1.119 and 1.120 #4046

ac1058 opened this issue May 10, 2024 · 1 comment

Comments

@ac1058
Copy link

ac1058 commented May 10, 2024

OpenUI5 version:
1.119, 1.120

Browser/version (+device/version):
Chrome

Any other tested browsers/devices(OK/FAIL):
N/A

URL (minimal example if possible):

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. open the sap.m.Dialog sample in UI5 sample docs
    • click Settings Cog in top right and select 'Belize' and 'Compact'
  2. Observe that in 1.119.x and 1.120.x the "Cancel" button has a border around it that did not exist in previous versions and versions >= 1.121.x

What is the expected result?

  • Belize Dialog's Cancel button should not have borders around it in 1.119 and 1.120, but previous versions and versions afterwards do not have it

What happens instead?

  • Cancel button has borders around it

Any other information? (attach screenshot if possible)

  • It appears the css here has been removed Belize Button.less in 1.119 and 1.120
.sapMIBar-CTX .sapMBtnInner,
.sapMBar .sapMBtnInner,
.sapMHeader-CTX .sapMBtnInner,
.sapMFooter-CTX .sapMBtnInner { 
    background: @sapUiButtonLiteBackground;
    border-color: @sapUiButtonLiteBorderColor;
}
@DonkeyCo
Copy link
Member

Thanks for reporting the issue. I've created an internal incident DINC0148190 for your reported issue. The colleagues will update you once they have news

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants