Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3C example breaks on layer move #879

Open
acefslaser opened this issue Jan 27, 2023 · 6 comments · Fixed by #883
Open

W3C example breaks on layer move #879

acefslaser opened this issue Jan 27, 2023 · 6 comments · Fixed by #883
Labels

Comments

@acefslaser
Copy link

acefslaser commented Jan 27, 2023

Hi! So while evaluating this project I found a issue on moving layers. Here is the example SVG I am using:

https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/gallardo.svg

Expected behavior
I would expect that the whole layer would be moved, not just a part of it.

SVG-Edit environment (IMPORTANT)

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Firefox
  • Version 109

Screenshots

gal1
gal2
gal3

Log

Uncaught TypeError: paint.transform is undefined
    recalculateDimensions http://localhost:8000/packages/svgcanvas/dist/svgcanvas.js:3362
    recalculateDimensions http://localhost:8000/packages/svgcanvas/dist/svgcanvas.js:3336
    recalculateDimensions http://localhost:8000/packages/svgcanvas/dist/svgcanvas.js:3336
    recalculateAllSelectedDimensions http://localhost:8000/packages/svgcanvas/dist/svgcanvas.js:2541
    recalculateAllSelectedDimensions http://localhost:8000/packages/svgcanvas/dist/svgcanvas.js:2541
    mouseUpEvent http://localhost:8000/packages/svgcanvas/dist/svgcanvas.js:2758
    SvgCanvas http://localhost:8000/packages/svgcanvas/dist/svgcanvas.js:5532
    init http://localhost:8000/src/editor/EditorStartup.js:118
    async* http://localhost:8000/src/editor/index.html:36
@jfhenon
Copy link
Collaborator

jfhenon commented Feb 6, 2023

I found some issues, could you try with the following link?
https://deploy-preview-883--svgedit.netlify.app/editor

@acefslaser
Copy link
Author

Definitely seems to have improved the situation, however the geometry on the wheels still breaks:

g1

g2

@acefslaser
Copy link
Author

https://www.w3.org/TR/SVG/implnote.html#ArcConversionCenterToEndpoint Might be of some help, since I believe the wheels are arcs

@jfhenon
Copy link
Collaborator

jfhenon commented Feb 7, 2023

Do you think you would be able to isolate the issue with a simpler SVG?

@acefslaser
Copy link
Author

Here ya go!:

gallardo-just-wheels

jfhenon added a commit that referenced this issue Mar 30, 2023
jfhenon added a commit that referenced this issue Mar 30, 2023
* create and use getTransformList
* update dependencies
@jfhenon jfhenon reopened this Mar 30, 2023
@jfhenon
Copy link
Collaborator

jfhenon commented Mar 30, 2023

The fix is partial so issue is reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants