Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor "BAKE_ARCHITECTURE" vs. "BAKE_ARCH" inconsistency #70

Open
bryantdrewjones opened this issue May 22, 2020 · 1 comment
Open

Minor "BAKE_ARCHITECTURE" vs. "BAKE_ARCH" inconsistency #70

bryantdrewjones opened this issue May 22, 2020 · 1 comment

Comments

@bryantdrewjones
Copy link
Contributor

See:

ut_setenv("BAKE_ARCH", UT_ARCH);

Bake's README lists "BAKE_ARCHITECTURE" as the environment variable used to specify processor architecture, but the line referenced above stores the initialized value in "BAKE_ARCH".

Would it be okay to submit a PR that corrects this? If you suspect that user code uses both "BAKE_ARCHITECTURE" and "BAKE_ARCH", we could maintain compatibility like this:

ut_setenv("BAKE_ARCH", UT_ARCH);
ut_setenv("BAKE_ARCHITECTURE", UT_ARCH);

...but it would be nice to simply replace "BAKE_ARCH" and have one definitive variable, if that sounds safe.

Cheers! ☺️

@SanderMertens
Copy link
Owner

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants