Stack overflow with two acyclic relations in opposite directions

[bbdb68]

I created an acyclic relation, and use is with child of, but in reverse order:

flecs::world world;
  flecs::entity relation = world.entity("relation").add(flecs::Acyclic);

  auto a = world.entity("a");
  auto b = world.entity("b");
  a.child_of(b);
  b.add(relation, a);

this made my code crash with stack overflow
Looks like my custom relation interferes with child_of, but I do not understand why

[SanderMertens]

Got it reproduced, it's a bug in the notification code. I'm currently doing a refactor of that code, will make sure this gets fixed as part of that.

[bbdb68]

great, thanks

[RicardRC]

I get the same with Transitive.
Somehow in my full code I triggered it with Exclusive too, but can't manage to trigger with exclusive on a minimum repro case.

#include "flecs.h"

struct ownedBy {};

int main()
{
	flecs::world universe;
	universe.component<ownedBy>().add(flecs::Transitive);
	//universe.component<ownedBy>().add(flecs::Acyclic);	// Also breaks

	auto woodGolemLeader = universe.entity();

	auto woodGolemCoreStation = universe.entity().add<ownedBy>(woodGolemLeader);

	woodGolemLeader.child_of(woodGolemCoreStation);
}

[SanderMertens]

This will take a bit longer to fix, I completed the refactor but it still had a few performance issues that will take some time to work through.

@RicardRC makes sense that this would also trigger with Transitive, adding Transitive automatically adds Acyclic.