Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: success or error state is not returning to SLAuthService #48

Closed
1 task done
N3v1 opened this issue Jan 13, 2024 · 2 comments
Closed
1 task done

[BUG]: success or error state is not returning to SLAuthService #48

N3v1 opened this issue Jan 13, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed P2 Medium priority issue scope: auth Issues with ScribbleLabs Authentication Service scope: core Core and other reusable codebase size: M Medium sized issue stale Issues that have not been triaged in an appropriate amount of time status: flagged internally For issues that have been flagged for staff attention in our internal channels. SwiftUI A swift bug type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. type: feature Threads classified to be feature requests. Implementation to be considered as a nice to have type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping.
Milestone
Authentication

Comments

@N3v1
Copy link
Member

N3v1 commented Jan 13, 2024 •
edited

Description

When you tap on the "Continue with Google" button and agree to the prompt to open google.com to sign in or sign up, Google will open and you can select your account. However, after that, the view will be dismissed and nothing will happen on your screen. But you will still be recorded on the dashboard as a user that used GID as a sign-in method.

Version

  • SLBuild number: 1
  • SLVersion number: 0.0.1-alpha
  • Plattform: iPadOS 17.2 (iOS)
  • Xcode Version: 15.2

To Reproduce

  1. Tab on the "Continue with google button"
  2. Agree on the redirection to google.com warning
  3. Select Google Account

Expected Behavior

  1. Type in your Google password
  2. Success state will be returned to ScribbleLab Auth Service
  3. UserSession isn't nil anymore

Additional Context

No response

Screenshots

No response

Is there an existing issue for this?

  • I have searched the existing issues
@N3v1 N3v1 added the type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. label Jan 13, 2024
@N3v1 N3v1 added this to the Authentication milestone Jan 13, 2024
@N3v1 N3v1 added good first issue Good for newcomers help wanted Extra attention is needed SwiftUI A swift bug scope: auth Issues with ScribbleLabs Authentication Service labels Jan 13, 2024
@N3v1 N3v1 added type: feature Threads classified to be feature requests. Implementation to be considered as a nice to have scope: core Core and other reusable codebase P2 Medium priority issue labels Feb 15, 2024
@N3v1 N3v1 changed the title 🔴 GID: success or error state is not returning to SLAuthService [BUG]: success or error state is not returning to SLAuthService Feb 16, 2024
@N3v1 N3v1 added status: flagged internally For issues that have been flagged for staff attention in our internal channels. type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping. labels Feb 16, 2024
@N3v1 N3v1 pinned this issue Feb 16, 2024
@N3v1 N3v1 added the size: M Medium sized issue label Feb 16, 2024
@N3v1
Copy link
Member Author

N3v1 commented Mar 12, 2024 •
edited

@ScribbleLabApp/scribble-lab-intern Do someone of you want to try to fix this issue?

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not been triaged in an appropriate amount of time label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed P2 Medium priority issue scope: auth Issues with ScribbleLabs Authentication Service scope: core Core and other reusable codebase size: M Medium sized issue stale Issues that have not been triaged in an appropriate amount of time status: flagged internally For issues that have been flagged for staff attention in our internal channels. SwiftUI A swift bug type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. type: feature Threads classified to be feature requests. Implementation to be considered as a nice to have type: showstopper Issues that are urgent and are critical path. These need immediate attention & shipping.
Projects
ScribbleLab Roadmap
Status: Done
Milestone
Authentication
Development

No branches or pull requests
1 participant
@N3v1