Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow choosing audio device #282

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: allow choosing audio device #282

wants to merge 4 commits into from

Conversation

SeaDve
Copy link
Owner

@SeaDve SeaDve commented Feb 17, 2024 •
edited

Fixes #227

TODO

  • Save the last selected device on the settings
  • Properly handle if there is no default device (use a custom row that becomes No Devices, instead of adding None on the list)
  • Adjust volume
  • See current volume level (via a GtkLevelBar or something)

FIXME

  • Use GstDevice.display_name instead of our own
  • Use GstDevice.reconfigure_element instead of creating an element and getting its device property

@SeaDve
feat: allow choosing audio device
0494986 
Closes #227
@SeaDve
fix: move timer right before pipeline is started
909e49a 
This is so errors could be presented as early as delay countdown.
@SeaDve SeaDve marked this pull request as draft February 17, 2024 04:25
@SeaDve
Copy link
Owner Author

SeaDve commented Feb 17, 2024 •
edited

I think this will be hard to integrate with the current UI, without having #264 first.

The future plan is to merge this PR to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] add ability to select microphone input in preferences
1 participant
@SeaDve