Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode warnings in two swift files #534

Open
ingopaulsen opened this issue Nov 10, 2023 · 2 comments
Open

Xcode warnings in two swift files #534

ingopaulsen opened this issue Nov 10, 2023 · 2 comments

Comments

@ingopaulsen
Copy link

Describe the bug
I have received the following warnings in Xcode for SwiftMessages package (the numbers in brackets indicate the frequency):

BaseView.swift:

(2) Non-'@objc' instance method in extensions cannot be overridden; use 'public' instead

SwiftMessagesSegue.swift:

(1) Unnecessary check for 'iOS'; enclosing scope ensures guard will always be true

Environment (please complete the following information):

  • Xcode version: Xcode 15.0
  • SwiftMessages Versions: v9.0.6, v9.0.9
  • Device: iPhone7
  • Simulator: iPhone15
  • OS: iOS 15+
@wtmoose wtmoose added the bug label Nov 30, 2023
@wtmoose
Copy link
Member

wtmoose commented Nov 30, 2023

Thanks for calling my attention to this.

wtmoose added a commit that referenced this issue Dec 3, 2023
@wtmoose
Copy link
Member

wtmoose commented Dec 3, 2023

I wasn't able to reproduce the warnings, but I made some guesses and I think it should be good now. Could you pull down the head of master and let me know if the warnings are cleared up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants