Wrong sorting of products in taxon after saving

[delyriand]

Sylius version affected: 1.2.11 and higher

Description

The position of the last products in a taxon is not correctly saved when there are more products than the taxon of the 1st productTaxon.

Because the getMaxPosition method in Sylius\Bundle\CoreBundle\Controller\ProductTaxonController class returns the wrong maximum position.
This is because when we load the "productTaxon" via the line $productTaxon = $this->findOr404($configuration); we have no criteria. So the SingleResourceProvider does a findOneBy with an empty array and returns the 1st "productTaxon".

Steps to reproduce

• with the default fixutres
• try to reorder all products in the Jeans taxon /admin/products/taxon/9
• position of 2 last product is "-1"

Possible Solution

We could define the criteria in the requestConfiguration before calling the getMaxPosition method. For example:

$firstProductTaxonId = array_key_first($productTaxonsPositions);
$configuration->getParameters()->set('criteria', ['id' => $firstProductTaxonId]);
$maxPosition = $this->getMaxPosition($configuration);

[jakubtobiasz]

Hi @delyriand,
can you tell use what values did you provide? We aren't able to reproduce your issue. It'd be great if you could record your screen 🙏🏻.

[delyriand]

Hi @jakubtobiasz,

I can't reproduce the -1 positions… But if you look at the "maxPosition" (via xdebug or similar) when saving product positions in Jeans taxon, you'll see that it's 5 but not 7.

And if you try to save these positions:

I should have:

• 666F
• 111F
• 000F
• …

Products are saved in the wrong order:

Does it help you reproduce my issue?