You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
The average product rating is updates through AverageRatingUpdater, this service is called by;
ReviewChangeListener;
the sylius_update_rating callback on the sylius_product_review state machine.
This means that the score is calculated twice for the accept transition; once through the callback and once after flushing the review (which you have to do in order to persist the new state value on the entity).
Steps to reproduce
Accept a review.
Possible Solution
Remove the sylius_update_rating callback from the sylius_product_review state machine. Don't think this is required anymore now that the ReviewChangeListener handles this (was added later).
The text was updated successfully, but these errors were encountered:
Hello @martijnc, your reported issue is valid. We will fix it later, in Sylius 2.0 release. However, if you'd like to try your hand at proposing the solution, it would be great. 🕺
Sylius version affected: 1.13
Description
The average product rating is updates through
AverageRatingUpdater
, this service is called by;ReviewChangeListener
;sylius_update_rating
callback on thesylius_product_review
state machine.This means that the score is calculated twice for the
accept
transition; once through the callback and once after flushing the review (which you have to do in order to persist the new state value on the entity).Steps to reproduce
Accept a review.
Possible Solution
Remove the
sylius_update_rating
callback from thesylius_product_review
state machine. Don't think this is required anymore now that theReviewChangeListener
handles this (was added later).The text was updated successfully, but these errors were encountered: