Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with SyliusResourceBundle 1.11 #16231

Closed
Zales0123 opened this issue May 8, 2024 · 2 comments
Closed

Incompatibility with SyliusResourceBundle 1.11 #16231

Zales0123 opened this issue May 8, 2024 · 2 comments
Labels
Bug Confirmed bugs or bugfixes.

Comments

@Zales0123
Copy link
Member

Sylius version affected: 1.13

Description

Hello folks 馃枛 Lastly I've tried to use Sylius 1.13 with SyliusResourceBundle 1.11-BETA.1... and it blew into my face 馃拑 Apparently, our new state machine abstraction is not compatible with the state machines abstractions introduced in the ResourceBundle 馃殌

Zrzut ekranu 2024-05-8 o 08 00 13

Here is a build that reproduced the problem: https://github.com/Zales0123/Sylius/actions/runs/8991118328/job/24698040812

馃
@Zales0123 Zales0123 added the Bug Confirmed bugs or bugfixes. label May 8, 2024
@Jibbarth
Copy link
Contributor

Jibbarth commented May 8, 2024 •
edited

I'm wondering if we should add the new abstraction in dependency of sylius/sylius.

I just had the issue right now on a sylius-standard project, after removing sylius/paypal-plugin.

It appears only this plugin has a dependency to the sylius/state-machine-abstraction, whereas it's used in order fixtures.

https://packagist.org/packages/sylius/state-machine-abstraction/dependents

EDIT:

Finally, not sure if it's related with your issue. 馃槄

@Zales0123 Zales0123 mentioned this issue May 14, 2024
Merged
lchrusciel added a commit to Sylius/SyliusResourceBundle that referenced this issue May 14, 2024
@lchrusciel
fix #871 Fix state machine tag (Zales0123)
40e795a 
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

馃憢 As Sylius introduced the state machine layer abstraction with its own `sylius.state_machine` service tag, we have a little conflict of configuration, which prevents using SyliusResourceBundle with Sylius 1.13 for now 馃拑 (see [this issue](Sylius/Sylius#16231))

For now, I propose we change the tag in this repository to `sylius_resource.state_machine` (which is also semantically more correct), but we should probably think if there is any thing we need to do on this repo according to this state machine abstraction 馃枛 

Commits
-------

136d602 Fix state machine tag
3b0e2e4 Supress MissingClassConstType for now
@GSadee
Copy link
Member

GSadee commented May 15, 2024

Hi @Zales0123,

thank you for reporting an issue and fixing the problem on SyliusResourceBundle, so I'm closing the issue as it has been fixed by Sylius/SyliusResourceBundle#871 馃枛馃徎

PS. @Jibbarth, it seems not to be related with this issue. To be honest, I thought that we solved that problem but probably it should be additionally checked. Feel free to open another issue if it still occurs

@GSadee GSadee closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jibbarth @GSadee @Zales0123