Tweaked Discord album art implementation to make it more reliable. Closes #1136. #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes issue #1136 |
Taiko2k
requested changes
Apr 29, 2024
There was a problem hiding this comment.
I'm not sure the caching mechanism still works as intended with this revision.
The goal is that we want to minimize any unnecessary repeated calls. Caching both results and failures. To this end I created the dicts pctl.album_mbid_cache and pctl.mbid_image_url_cache. These can be changed as needed, though your change has implications for how the former of the two works.
Could you revise the PR to ensure we don't make an API call with the same data twice. (within in the same session). You can revise the caching mechanism and associated variables as needed.
|
Good points, I will revise my implementation |
|
That should fix the caching issues I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now uses both
release_group_idandrelease_id, which makes it significantly more reliable.