Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page in the documentation #7395

Closed
p-pey opened this issue May 8, 2024 · 4 comments · Fixed by #7398
Closed

404 page in the documentation #7395

p-pey opened this issue May 8, 2024 · 4 comments · Fixed by #7398
Labels
documentation Improvements or additions to documentation v4

Comments

@p-pey
Copy link

p-pey commented May 8, 2024

Describe the bug

at end of the this document https://tanstack.com/query/v4/docs/reference/QueryCache, there is a link to https://tanstack.com/query/v4/docs/reference/QueryCache/framework/react/community/tkdodos-blog#18-inside-react-query that it is not exist

Your minimal, reproducible example

https://tanstack.com/query/v4/docs/reference/QueryCache/framework/react/community/tkdodos-blog#18-inside-react-query

Steps to reproduce

link that missing:
https://tanstack.com/query/v4/docs/reference/QueryCache/framework/react/community/tkdodos-blog#18-inside-react-query

Expected behavior

should open community page

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

Windows 10 - google chrome

Tanstack Query adapter

None

TanStack Query version

4

TypeScript version

No response

Additional context

No response

@p-pey
Copy link
Author

p-pey commented May 8, 2024

@TkDodo
Copy link
Collaborator

TkDodo commented May 10, 2024

yeah the links are fixed for v5 and latest, but not v4. @fulopkovacs is that something we could port back to the v4 branch ?

@TkDodo TkDodo added documentation Improvements or additions to documentation v4 labels May 10, 2024
@TkDodo
Copy link
Collaborator

TkDodo commented May 10, 2024

oh, I see we already have a draft PR?

@fulopkovacs
Copy link
Contributor

yeah the links are fixed for v5 and latest, but not v4. @fulopkovacs is that something we could port back to the v4 branch ?

oh, I see we already have a draft PR?

#7398

Yes, I'm already working on it! ☺️

@TkDodo TkDodo closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants